Conversation
See seL4 seL4/seL4@e7bb62d2 for rationale. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
Indanz
left a comment
Indanz
left a comment
There was a problem hiding this comment.
Is it really necessary for all those CMake files to have a minimum CMake version specified, can't whichever CMake file includes them do that instead? I guess not.
Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
We can't really tell from this repo where they will be included and the minimum version requirement here is supposed to tell the including file whether it's compatible or not. So I don't think we should remove them. |
These are superseded by the corresponding files in LICENSES and the SPDX tags. Signed-off-by: Gerwin Klein <gerwin.klein@proofcraft.systems>
|
Have updated the cmake style of the files that are touched, but am leaving out the vendored external libraries, so I'm expecting the style checker to still complain about those. That should not be a problem any more in future PRs, though, since we're not planning to change them. |
2 participants
See seL4 seL4/seL4@e7bb62d2 for rationale.