add tests to cover running simple query#8
Open
mzuber-r7 wants to merge 1 commit intoseamusc:masterfrom
Open
Conversation
ashulga-r7
reviewed
Feb 6, 2019
Collaborator
ashulga-r7
left a comment
ashulga-r7
left a comment
There was a problem hiding this comment.
The LogSearch.search accepts 8 params. How about adding test cases for valid/invalid values of the params?
test/basic_test.py
Outdated
| text='ok' | ||
| ) | ||
| ls = LogSearch(api_key='dummy_key') | ||
| m.get("https://eu.rest.logs.insight.rapid7.com/management/organizations/apikeys", |
Collaborator
There was a problem hiding this comment.
How about extracting global string const for base URL?
Collaborator
Author
There was a problem hiding this comment.
I can see that you did that, so I'm gonna copy yours
ashulga-r7
approved these changes
Feb 7, 2019
ashulga-r7
reviewed
Feb 7, 2019
Collaborator
ashulga-r7
left a comment
ashulga-r7
left a comment
There was a problem hiding this comment.
Actually there are some issues with build for python 3.x.
Collaborator
Author
|
yeah...I see |
mzuber-r7
force-pushed
the
add_tests_to_cover_simple_query
branch
from
b637331 to
312d776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest.ini+pytest-pythonpathadded@seamusc