Skip to content

Android - sometimes GetCookie() returns null, so .Split() is not possible. Simple check added #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashantiel wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Android - sometimes GetCookie() returns null, so .Split() is not possible. Simple check added #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions Cookies.Android/CookieWebViewRenderer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,20 @@ public override void OnPageFinished(global::Android.Webkit.WebView view, string
{
var cookieHeader = CookieManager.Instance.GetCookie(url);
var cookies = new CookieCollection();
var cookiePairs = cookieHeader.Split('&');
foreach (var cookiePair in cookiePairs)
if (cookieHeader != null)
{
var cookiePieces = cookiePair.Split('=');
if (cookiePieces[0].Contains(":"))
cookiePieces[0] = cookiePieces[0].Substring(0, cookiePieces[0].IndexOf(":"));
cookies.Add(new Cookie
var cookiePairs = cookieHeader.Split('&');
foreach (var cookiePair in cookiePairs)
{
Name = cookiePieces[0],
Value = cookiePieces[1]
});
var cookiePieces = cookiePair.Split('=');
if (cookiePieces[0].Contains(":"))
cookiePieces[0] = cookiePieces[0].Substring(0, cookiePieces[0].IndexOf(":"));
cookies.Add(new Cookie
{
Name = cookiePieces[0],
Value = cookiePieces[1]
});
}
}

_cookieWebView.OnNavigated(new CookieNavigatedEventArgs
Expand Down