Additional ceph disks for clusters

[dahoat-sprecher]

Hello to All,

As we noticed, the guest.xml.j2 contained partial support for (one) additional disk(s) for VMs. This Pull Request adds this feature also to clusters for an arbitrary amount of disks. However, this contains also a breaking change as the inventory for a VM uses a map instead of a list:

 additional_disk:
     vdb: "../files/data.qcow2" # TODO: Replace with your disk image

However, this permits explicitly naming additional disks.
See also: seapath/ansible#893

Best regards,
Daniel

[eroussy]

Hi @dahoat-sprecher

Thanks for the PR, it is a complicated one and it will have to be tested properly.
I have made some comments here and on the ansible PR. I will have another SEAPATH maintainer have a look also

[dahoat-sprecher]

I rebased the branch on top of the current main branch. vm_manager_cluster.py required merging.

[eroussy]

Can you add an option in vm_manager CLI to add additional disks in the VM ?

[dahoat-sprecher]

I added a --additional-disk CLI option to vm_manager (cluster mode). The new test file tests/test_vm_manager_cmd.py contains both argparse unit tests and an end-to-end test that drives main() through the real backend to verify the CLI→backend string contract (additional_disks).

However, I introduced some code duplication:

• test_vm_manager_cmd.py copies ~50 lines from test_vm_manager_cluster.py:
  • TESTDATA_XML_PATH
  • the XML-reading helper
  • vm_name / qcow2_image / additional_qcow2_images fixtures (renamed to cli_*).

The duplicates exist because test_vm_manager_cluster.py defines its fixtures locally and deliberately shadows the libvirt-level vm_name fixture from tests/conftest.py with a cluster-level cleanup version.
Options

• (A) Reorganize into tests/cluster/ with its own conftest.py, requires CI's --ignore=tests/test_vm_manager_cluster.py to be updated to --ignore=tests/cluster.
• (B) Extract only the harmless bits (XML helper + constant), keep the fixture duplication. Minimal change, ~15 lines saved.
• (C) Leave as-is — accept 50 lines of duplication, but keep both files independent.

Which option do you prefer?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[dupremathieu]

LGTM