Add XML generator to create libvirt domain XML from CLI options#90
Draft
dupremathieu wants to merge 1 commit into
Draft
Add XML generator to create libvirt domain XML from CLI options#90dupremathieu wants to merge 1 commit into
dupremathieu wants to merge 1 commit into
Conversation
Make --xml optional in `vm-mgr create`. When omitted, XML is generated from new CLI flags (--vcpus, --memory, --cpuset, --rt, --hugepages, --balloon, --vnc, --secure-boot, --net, etc.), removing the need for a pre-existing XML file. This unblocks the Cockpit webui to pass individual VM parameters directly via the CLI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Mathieu Dupré <mathieu.dupre@savoirfairelinux.com>
3afd6ae to
a498bb9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Make --xml optional in
vm-mgr create. When omitted, XML is generated from new CLI flags (--vcpus, --memory, --cpuset, --rt, --hugepages, --balloon, --vnc, --secure-boot, --net, etc.), removing the need for a pre-existing XML file. This unblocks the Cockpit webui to pass individual VM parameters directly via the CLI.