Content Security Policy: Replace style attributes with JavaScript styles#41
Open
zepich wants to merge 2 commits intoseballot:masterfrom
Open
Content Security Policy: Replace style attributes with JavaScript styles#41zepich wants to merge 2 commits intoseballot:masterfrom
zepich wants to merge 2 commits intoseballot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To use the Spectrum Color Picker on a website with a Content Security Policy header, the use of the attribute
styleis only allowed if the header contains the paramunsafe-inline. With this param, the header is more or less useless for CSS protection. If you have a CSP header, you do not want the paramunsafe-inlinein it.The solution for this problem is straightforward: Instead of setting the attribute directly, we must use the JavaScript API to set the style properties.
To solve this, I've replaced the code with style attributes with jQuery elements to set the style values with the method
.css().