Skip to content

test: replace external standards fixture - #61

Open
swernerx wants to merge 1 commit into
mainfrom
agent/replace-external-standards-fixture
Open

test: replace external standards fixture#61
swernerx wants to merge 1 commit into
mainfrom
agent/replace-external-standards-fixture

Conversation

@swernerx

Copy link
Copy Markdown
Member

Summary

  • replace the external standards-test-repo2 consumer canary with a versioned in-repository GitHub consumer fixture
  • add end-to-end coverage for upgrading standards 0 → 7, GitHub workflow selection, consumer-owned config preservation, clean checks, and idempotent re-application
  • update historical notes to document the archived external fixture and the remaining live-integration boundary

Why

The dedicated external repository duplicated state and required manual cross-repository coordination. A checked-in fixture covers the deterministic consumer behavior directly in the standards test suite. Actual GitHub repository settings, Actions execution, Renovate scheduling, and cross-repository PR behavior remain intentionally outside the local test boundary.

Validation

  • CI=true pnpm agent:check
  • 77 tests passing
  • lint, formatting, typecheck, build, and standards self-check passing

@swernerx
swernerx requested a review from fastner July 29, 2026 16:14
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown

Greptile Summary

This PR replaces an external consumer canary with a versioned local fixture and expands deterministic upgrade coverage.

  • Adds a GitHub consumer fixture starting at standards version 0.
  • Tests platform-specific workflow selection, consumer-owned configuration preservation, clean checks, and idempotent re-application.
  • Updates historical documentation to identify the archived fixture and clarify the remaining live-integration boundary.

Confidence Score: 5/5

The PR appears safe to merge, with the new fixture resolving correctly under the repository’s test execution model and exercising the intended mechanical consumer upgrade.

The changes are confined to tests, fixtures, and historical documentation; the fixture is copied from the source test directory, the assertions match the current manifest and apply/check behavior, and no concrete regression or security issue was identified.

Important Files Changed

Filename Overview
test/standards.test.ts Adds a source-relative fixture copier and end-to-end upgrade test consistent with the repository's Vitest execution and apply/check contracts.
test/fixtures/github-consumer/.repometa.json Defines a private GitHub consumer at standards version 0, enabling the intended full mechanical migration path.
test/fixtures/github-consumer/package.json Provides Node-scope detection while remaining consumer-owned and unchanged by standards application.
test/fixtures/github-consumer/renovate.json Provides an existing seeded configuration used to verify preservation of consumer-owned content.
test/fixtures/README.md Accurately documents the deterministic behaviors covered by the fixture and the live-service behaviors left outside the test boundary.
changes/0003-platform-aware-ci.md Replaces obsolete external-fixture coordination notes with the archived-repository and local-fixture status.
changes/0004-ci-workflow-forgejo.md Updates historical fixture notes without changing the documented migration behavior.

Reviews (1): Last reviewed commit: "test: replace external standards fixture" | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant