Skip to content

fix: correct type of verson in CustomAdaptiveCard#30

Open
tinect wants to merge 2 commits intosebbmeyer:masterfrom
tinect:fix/versionType
Open

fix: correct type of verson in CustomAdaptiveCard#30
tinect wants to merge 2 commits intosebbmeyer:masterfrom
tinect:fix/versionType

Conversation

@tinect
Copy link
Copy Markdown

@tinect tinect commented Jul 8, 2024

Version must be a string otherwise, M$ will answer with an exception.
Additionally, the new workflow will result with empty string instead of "1".

@sebbmeyer
Copy link
Copy Markdown
Owner

Thanks @tinect for the PR, it will try to review it as soon as I can

@janmyszkier
Copy link
Copy Markdown
Contributor

@sebbmeyer I can confirm this is needed and PR is correct. Eventually might be a good idea to change all versions around the code to strings like it's done in https://github.com/sebbmeyer/php-microsoft-teams-connector/blob/master/src/Cards/Adaptive/BaseAdaptiveCard.php#L23

@sebbmeyer
Copy link
Copy Markdown
Owner

@janmyszkier thanks for checking the PR. I try check every open PR on the weekend and merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants