Fix NS7 build#14
Open
tralves wants to merge 4 commits intosebestindragos:masterfrom
Open
Conversation
|
@sebestindragos could you merge this and release a new version? The current 2.0.0 version crashes applications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #8 and #12. Making this package work properly in NS7.
The type references were wrong and the
ts-patchcommand was in thecleanscript instead of thebuild, which is probably why the published version is wrong.Please re-publish this package when you have time. Meanwhile, I will be using my fork like this: