Override headers#227
Merged
Merged
Conversation
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
2 tasks
sebpretzer
commented
Dec 18, 2025
sebpretzer
left a comment
Owner
Author
There was a problem hiding this comment.
self-review complete
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for overriding V2 API request headers to address issues where TickTick returns 429 errors due to outdated headers. The changes enable users to customize the User-Agent and X-Device headers when the default values become invalid.
- Introduces configurable
v2_user_agentandv2_x_devicesettings with sensible defaults - Adds warning message when 429 errors occur to guide users to header override documentation
- Provides comprehensive documentation explaining how to find and set valid header values
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pyticktick/settings.py | Adds V2XDevice model and configurable header fields; removes hardcoded header values; adds warning for 429 errors |
| tests/unit/test_settings.py | Adds comprehensive test coverage for new header configuration functionality |
| docs/guides/settings/overriding_outdated_headers.md | New documentation explaining header override feature with examples |
| mkdocs.yaml | Adds navigation entry for new documentation page |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #212 and #226