Add support for ty#245
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the ty type checker alongside the existing pyright type checker by adding type ignore comments for both tools.
Changes:
- Added
tyas a development dependency - Added
tyignore comments throughout the codebase alongside existingpyrightandmypyignore comments - Updated import in test file to use
timezone.utcinstead of deprecatedUTC - Added
tyto pre-commit hooks
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added ty>=0.0.11 to mypy dependencies |
| .pre-commit-config.yaml | Added ty pre-commit hook configuration |
| tests/unit/test_settings.py | Added ty ignore comment for invalid argument type |
| tests/unit/test_pydantic.py | Added ty ignore comments for attribute access and subscript issues |
| tests/integration/v2/test_task.py | Added ty ignore comments for argument types and iteration |
| tests/integration/v2/test_closed.py | Added ty ignore comments and updated UTC import to timezone.utc |
| tests/integration/v2/test_batch.py | Added ty ignore comments for argument types and iteration |
| tests/integration/conftest.py | Added ty ignore comment for unknown argument |
| src/pyticktick/pydantic.py | Added ty ignore comment for unused ignore comment |
| src/pyticktick/logger.py | Added ty ignore comment for unused ignore comment |
| scripts/generate_v1_token.py | Added ty ignore comment for unused ignore comment |
| scripts/checks/pypi_version.py | Added Python version check for tomllib availability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sebpretzer
commented
Jan 12, 2026
sebpretzer
left a comment
Owner
Author
There was a problem hiding this comment.
self-review complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #244