Skip to content

Add support for ty#245

Merged
sebpretzer merged 3 commits into
mainfrom
add_support_for_ty
Jan 12, 2026
Merged

Add support for ty#245
sebpretzer merged 3 commits into
mainfrom
add_support_for_ty

Conversation

@sebpretzer

Copy link
Copy Markdown
Owner

Closes #244

Copilot AI review requested due to automatic review settings January 12, 2026 00:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the ty type checker alongside the existing pyright type checker by adding type ignore comments for both tools.

Changes:

  • Added ty as a development dependency
  • Added ty ignore comments throughout the codebase alongside existing pyright and mypy ignore comments
  • Updated import in test file to use timezone.utc instead of deprecated UTC
  • Added ty to pre-commit hooks

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Added ty>=0.0.11 to mypy dependencies
.pre-commit-config.yaml Added ty pre-commit hook configuration
tests/unit/test_settings.py Added ty ignore comment for invalid argument type
tests/unit/test_pydantic.py Added ty ignore comments for attribute access and subscript issues
tests/integration/v2/test_task.py Added ty ignore comments for argument types and iteration
tests/integration/v2/test_closed.py Added ty ignore comments and updated UTC import to timezone.utc
tests/integration/v2/test_batch.py Added ty ignore comments for argument types and iteration
tests/integration/conftest.py Added ty ignore comment for unknown argument
src/pyticktick/pydantic.py Added ty ignore comment for unused ignore comment
src/pyticktick/logger.py Added ty ignore comment for unused ignore comment
scripts/generate_v1_token.py Added ty ignore comment for unused ignore comment
scripts/checks/pypi_version.py Added Python version check for tomllib availability

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/checks/pypi_version.py Outdated
@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/pyticktick
  logger.py 43-44
  pydantic.py
Project Total  

This report was generated by python-coverage-comment-action

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@sebpretzer sebpretzer left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-review complete

@sebpretzer sebpretzer merged commit d867f0a into main Jan 12, 2026
11 checks passed
@sebpretzer sebpretzer deleted the add_support_for_ty branch January 12, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for ty

2 participants