Skip to content

This was a regression in #79 #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebsjames merged 1 commit into from
Oct 12, 2025
Merged

This was a regression in #79 #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions mplot/VisualBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,20 +764,21 @@ namespace mplot {
// Rotate about the point this->rotation_centre. Subroutine for computeSceneview.
void computeSceneview_about_rotation_centre()
{
sm::mat44<float> sv;
sm::mat44<float> sv_tr;
sm::mat44<float> sv_rot;
if (this->ptype == perspective_type::orthographic || this->ptype == perspective_type::perspective) {
sv.translate (this->scenetrans_delta);
sv_tr.translate (this->scenetrans_delta);
// A rotation delta in world frame about the 'screen centre'
sv.translate (this->rotation_centre);
sv.rotate (this->rotation_delta);
sv.translate (-this->rotation_centre);
sv_rot.translate (this->rotation_centre);
sv_rot.rotate (this->rotation_delta);
sv_rot.translate (-this->rotation_centre);
} else {
// Only rotate in cyl view
sv.rotate (this->rotation_delta);
sv_rot.rotate (this->rotation_delta);
}

this->sceneview = sv * this->savedSceneview;
this->sceneview_tr = sv * this->savedSceneview_tr;
this->sceneview = sv_tr * sv_rot * this->savedSceneview;
this->sceneview_tr = sv_tr * this->savedSceneview_tr;
}

void computeSceneview()
Expand Down