Add OnAcceleratedPaint support with D3D11/GL interop for GPU-resident texture sharing#26
Add OnAcceleratedPaint support with D3D11/GL interop for GPU-resident texture sharing#26roxanneskelly wants to merge 5 commits into
Conversation
… texture sharing Enable CEF's shared texture mode and add an OnAcceleratedPaint override to dullahan_render_handler that passes the D3D11 shared texture handle through a new onAcceleratedPageChanged callback. On Windows, the opengl-example now uses WGL_NV_DX_interop2 to display the shared texture directly via GL without CPU readback. CEF's keyed-mutex shared textures are copied to a plain local D3D11 texture for interop compatibility. Mac/Linux accelerated paint paths are stubbed out. Also extracts GetParentProcess into a shared dullahan_platform_utils.h header, adds RelWithDebInfo build support with /DEBUG:FULL PDBs, and links d3d11/dxgi for the opengl-example on Windows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use shared_texture_io_surface on macOS instead of shared_texture_handle. Linux does not support accelerated painting and falls back to OnPaint. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
LUIDs are a Windows-specific concept used by DXGI to identify GPU adapters and have no equivalent on macOS or Linux. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
callumlinden
left a comment
callumlinden
left a comment
There was a problem hiding this comment.
Looks good and I'm thrilled to hear that it works. Initial questions:
- There is a lot happening in the original OnPaint() override that isn't present in your accelerated version. Code to take account of "popups" (PET_POPUP) for example - not what you might think - more for widgets like comboboxes that create an additional OS window to host parts of the widget - that needs to be dealt with. I'm about to build your branch to see it working - I'll try combo boxes - there is a section in the test bookmarks app for them.
- Is there is complementary pattern for macOS - I think the answer is yes - or do we just fall back to the non-accelerated OnPaint for both macOS and Linux?
- Do you foresee this being merged and added to a Viewer? I imagine the Viewer side work needs to land first if you do.
|
After trying it in the test app, I noticed that for some sites, when you have 2 windows open, one of the instances stutters and stops rendering for a second or two, every few seconds.. WebGL and video sites were the ones I tried - some contention for the GPU perhaps? |
|
Yeah, the stutter is a problem. Geenz was going to look into it at some point, so no merging until then. Unfortunately, Mac and Linux equivalent don't work. They used to, but due to some rearchitecting of CEF they don't any more. |
|
I confirmed that we do need the additional code in OnAcceleratedPaint to deal with edge cases like combo boxes. There are a billion examples out there of course but this page, selected at random, illustrates the issue https://web.pdx.edu/~bjpd/cwbase/dijit/tests/form/test_ComboBox.html (Only for some of them though which is surprising). |
2 participants
Enable CEF's shared texture mode and add an OnAcceleratedPaint override to dullahan_render_handler that passes the D3D11 shared texture handle through a new onAcceleratedPageChanged callback. On Windows, the opengl-example now uses WGL_NV_DX_interop2 to display the shared texture directly via GL without CPU readback. CEF's keyed-mutex shared textures are copied to a plain local D3D11 texture for interop compatibility. Mac/Linux accelerated paint paths are stubbed out.
Also extracts GetParentProcess into a shared dullahan_platform_utils.h header, adds RelWithDebInfo build support with /DEBUG:FULL PDBs, and links d3d11/dxgi for the opengl-example on Windows.