Merge builtin-functions into global-functions - #133
Merged
Conversation
tapple
marked this pull request as draft
May 13, 2026 19:13
tapple
commented
May 13, 2026
| ) | ||
|
|
||
|
|
||
| declare function assert<T>(value: T?, message: string?): T |
Contributor
Author
There was a problem hiding this comment.
assert,require,select, andsetmetatablewill be removed again in Mark the functions that have a magic type #130
tapple
commented
May 13, 2026
Comment on lines
+250
to
+253
| declare function require(target: string): any | ||
| declare function select(i: string | number, ...any): any | ||
| declare setfenv: nil | ||
| declare function touuid(val: string? | buffer | uuid): uuid? | ||
| declare function tovector(val: string? | vector): vector? | ||
| declare function setmetatable(t: { [any]: any }, mt: { [any]: any }?): () |
Contributor
Author
There was a problem hiding this comment.
assert,require,select, andsetmetatablewill be removed again in Mark the functions that have a magic type #130
This was referenced May 19, 2026
tapple
force-pushed
the
merge-slua-functions
branch
from
May 26, 2026 17:11
74406ab to
004de7f
Compare
tapple
marked this pull request as ready for review
May 26, 2026 17:11
HaroldCindy
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbeddedBuiltinDefinitions.cpp#122global-functionsare global functions that slua addedbuiltin-functionsare global functions that came with luauThere's really no reason to separate them. Combine them into one yaml section. I also properly sorted the global slua functions. They weren't before.
I made sure nothing changed by
slua_definitions.yaml