Convert Lua's python data structure from list to dict - #161
Merged
Conversation
tapple
commented
Jun 24, 2026
tapple
commented
Jun 24, 2026
tapple
commented
Jun 24, 2026
tapple
force-pushed
the
slua-dict
branch
2 times, most recently
from
July 13, 2026 14:20
62e859b to
1887b1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EmbeddedBuiltinDefinitions.cpp#122A lot (all?) of the lua generators need to look up things by name, and that's easier if the internal data structure is a dict, not a list. Python-only change
The generators that need the most access to modules and classes by name are:
EmbeddedBuiltinDefinitions.cpp#181