Remove invalid characters from SendGrid API key in test data#31
Merged
Conversation
The demo SendGrid key was 75 characters and no longer matched after @secretlint/secretlint-rule-sendgrid added strict 69-character length validation (secretlint/secretlint#1132). Trim the trailing 'ewhere' so the demo triggers detection again. Refs secretlint/secretlint#1509 Co-authored-by: azu <azu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the SendGrid API key in the demo so the rule actually detects it.
@secretlint/secretlint-rule-sendgridenforces the official 69-character length (secretlint/secretlint#1132). The previous demo token was 75 characters (...L5528Kewhere), so the rule skipped it and the demo no longer showed a SendGrid finding. Trimmingewherebrings it to exactly 69 characters and restores detection.Changes
src/DEFAUT_TEXT.ts:...L5528Kewhere→...L5528K(69 chars)Closes secretlint/secretlint#1509
https://claude.ai/code/session_01FomGx1tfHbHaq5dT3ZLViJ