Add ML-DSA support#1124
Draft
jku wants to merge 5 commits into
Draft
Conversation
This is related to proposed TAP: theupdateframework/taps#195 This currently enables the key for verification and signing for easier testing: In reality we may want to leave the verify support disabled until the TAP is approved. This makes cryptography 48 a requirement * we could make this more complicated with a separate feature but I'm not going to unless someone has a good reason for it * ML-DSA support was added in 47 already but support via openssl only became available in 48 Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Collaborator
Author
|
Test run on GCP: https://github.com/secure-systems-lab/securesystemslib/actions/runs/25749092040/job/75620285276: looks ok |
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
The skip is for SSLibKey._verify: I think it makes sense to be a longer function Signed-off-by: Jussi Kukkonen <jkukkonen@google.com>
jku
commented
May 13, 2026
| ]: | ||
| if not isinstance(private_key, RSAPrivateKey): | ||
| raise ValueError(f"invalid rsa key: {type(private_key)}") | ||
| assert_type("rsa", private_key, RSAPrivateKey) |
Collaborator
Author
There was a problem hiding this comment.
all these assert tweaks are just to keep linter happy ("too many branches"): the functionality should not change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a DRAFT implementation of a proposed TAP: theupdateframework/taps#195
This currently enables the ML-DSA for verification and signing by default for easier testing: In reality, if the TAP stays unapproved, we may want to leave the verify support disabled until TAP is approved.
Support is added to
This makes cryptography 48 a requirement
Currently sigstore is not compatible with new cryptography so those tests fails -- it just needs a new release
The test code is from AI.