Fix initial WebSocket connect after sync init#42
Open
d180 wants to merge 2 commits into
Open
Conversation
Contributor
|
The test is failing. Could you address that? Otherwise looks fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the SDK WebSocket startup path when
adrian.init()runs before an event loop exists. The first async send now starts the initial background connect task instead of buffering frames forever, and a regression test covers the sync-init case.Solves #41
Test plan
adrian.init(...)left_connect_task=None, and first async send only buffered the framesdk/.venv/bin/python -m py_compile sdk/adrian/ws.py sdk/tests/test_init.pyChecklist