Conversation
🦋 Changeset detectedLatest commit: 6f5d6f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SissonJ
left a comment
SissonJ
left a comment
There was a problem hiding this comment.
Nice work!
Can we rename PublicEvents to PublicLogs to gain consistency with the smart contract?
| action: Record<string, any> | ||
| } | ||
|
|
||
| type PaginatedPublicEvent = { |
There was a problem hiding this comment.
use ParsedPagination<PublicEvent[]>
There was a problem hiding this comment.
So the reason i did not use this name is becasue the name already exists.
There was a problem hiding this comment.
Which name already exists?
| } | ||
|
|
||
| // Paginated response type for public events | ||
| type GetPublicEventsResponse = PaginatedResponse<PublicEventResponse>; |
There was a problem hiding this comment.
Should be <PublicEventResponse[]> correct?
| const contractAddress = 'secret18537ttv4l4k2ea0xp6ay3sv4c243fyjtj2uqz7'; | ||
| const lcdEndpoint = 'https://api.secret.com'; | ||
| const chainId = 'secret-4'; |
There was a problem hiding this comment.
I would just switch these to MOCK_VALUES so that it's clear we aren't actually querying real data via the test.
AustinWoetzel
left a comment
AustinWoetzel
left a comment
There was a problem hiding this comment.
just a few more minors from me. Otherwise looks good!
| return batchQuery$({ | ||
| contractAddress: queryRouterContractAddress, | ||
| codeHash: queryRouterCodeHash, | ||
| contractAddress: queryPublicLogsContractAddress, |
There was a problem hiding this comment.
this is not correct, the batch query requires the query router.
Money market reward pools
* feat: more types * feat: start
* feat: building * feat: get_vaults msg switch * feat: updated liquidation_enabled * feat: remove console logs * feat: done * feat: lock file * feat: comments
Money-market-dcos
* feat: make changes for the contract interface change * feat: remove conosles
Js014 merge develop
chore: bump secretjs
4 participants
No description provided.