Skip to content

fix: set explicit RHTAS service URLs in gitsign e2e test#71

Merged
osmman merged 1 commit into
mainfrom
fix-gitsign-service-urls
May 18, 2026
Merged

fix: set explicit RHTAS service URLs in gitsign e2e test#71
osmman merged 1 commit into
mainfrom
fix-gitsign-service-urls

Conversation

@osmman
Copy link
Copy Markdown
Contributor

@osmman osmman commented May 15, 2026

Summary

  • Adds explicit gitsign.fulcio, gitsign.rekor, and gitsign.issuer URLs to the git config in the gitsign e2e test, matching the pattern already used in the rekorsearchui test
  • Adds api.FulcioURL to the mandatory config check so the test fails fast if the URL is missing

Without these, gitsign falls back to fulcio.sigstore.dev (public Sigstore), causing the test to fail when the RHTAS Keycloak OIDC token is rejected by the public Fulcio instance.

Test plan

  • Verify gitsign e2e test passes in CI against an RHTAS deployment
  • Confirm no regression in rekorsearchui test (uses the same pattern)

🤖 Generated with Claude Code

Without explicit fulcio/rekor/issuer URLs in the git config, gitsign
falls back to public Sigstore defaults (fulcio.sigstore.dev), causing
test failures when the OIDC token from RHTAS Keycloak is rejected by
the public instance.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@qodo-for-securesign
Copy link
Copy Markdown

Review Summary by Qodo

Set explicit RHTAS service URLs in gitsign e2e test

🐞 Bug fix

Grey Divider

Walkthroughs

Description
• Adds explicit RHTAS service URLs to gitsign git config
• Prevents fallback to public Sigstore defaults
• Adds FulcioURL to mandatory config validation
• Ensures OIDC token compatibility with RHTAS deployment
Diagram
flowchart LR
  A["Gitsign Config"] -->|Add explicit URLs| B["Fulcio URL"]
  A -->|Add explicit URLs| C["Rekor URL"]
  A -->|Add explicit URLs| D["Issuer URL"]
  E["Mandatory Config Check"] -->|Include| B
  B -->|Prevent fallback to| F["Public Sigstore"]
  C -->|Prevent fallback to| F
  D -->|Prevent fallback to| F
Loading

Grey Divider

File Changes

1. test/gitsign/gitsign_sign_verify_test.go 🐞 Bug fix +4/-1

Configure explicit RHTAS URLs for gitsign

• Added api.FulcioURL to mandatory config validation check
• Configured gitsign with explicit fulcio, rekor, and issuer URLs from RHTAS
• Prevents gitsign from falling back to public Sigstore defaults
• Ensures OIDC token from RHTAS Keycloak is accepted by configured services

test/gitsign/gitsign_sign_verify_test.go


Grey Divider

Qodo Logo

@qodo-for-securesign
Copy link
Copy Markdown

qodo-for-securesign Bot commented May 15, 2026

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Qodo Logo

@osmman osmman requested review from kdacosta0 and petrpinkas May 15, 2026 12:04
@osmman osmman merged commit a82e5fb into main May 18, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants