fix: set explicit RHTAS service URLs in gitsign e2e test#71
Merged
Conversation
Without explicit fulcio/rekor/issuer URLs in the git config, gitsign falls back to public Sigstore defaults (fulcio.sigstore.dev), causing test failures when the OIDC token from RHTAS Keycloak is rejected by the public instance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Review Summary by QodoSet explicit RHTAS service URLs in gitsign e2e test
WalkthroughsDescription• Adds explicit RHTAS service URLs to gitsign git config • Prevents fallback to public Sigstore defaults • Adds FulcioURL to mandatory config validation • Ensures OIDC token compatibility with RHTAS deployment Diagramflowchart LR
A["Gitsign Config"] -->|Add explicit URLs| B["Fulcio URL"]
A -->|Add explicit URLs| C["Rekor URL"]
A -->|Add explicit URLs| D["Issuer URL"]
E["Mandatory Config Check"] -->|Include| B
B -->|Prevent fallback to| F["Public Sigstore"]
C -->|Prevent fallback to| F
D -->|Prevent fallback to| F
File Changes1. test/gitsign/gitsign_sign_verify_test.go
|
SequeI
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gitsign.fulcio,gitsign.rekor, andgitsign.issuerURLs to the git config in the gitsign e2e test, matching the pattern already used in therekorsearchuitestapi.FulcioURLto the mandatory config check so the test fails fast if the URL is missingWithout these, gitsign falls back to
fulcio.sigstore.dev(public Sigstore), causing the test to fail when the RHTAS Keycloak OIDC token is rejected by the public Fulcio instance.Test plan
🤖 Generated with Claude Code