Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Can you pull from develop and resolve conflicts? Also @DicksonWu654 can you review this? |
Deploying frameworks with
|
| Latest commit: |
e888cbb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6b7a4939.frameworks-573.pages.dev |
| Branch Preview URL: | https://certs-refs.frameworks-573.pages.dev |
|
I don't know why nobody commented on this already, or why nobody flagged what's happening here 😅 . Just ask for help or tag me if you're stuck, folks <3. This is a bigger issue, not that it will be complicated to solve. But by using mdx files to add certs, we're essentially breaking gray-matter reads YAML files, since title is mentioned several times, and it is expected to find only one. Will work on a patch for this |
Add error handling for frontmatter parsing.
|
Ah sorry - I put my comments in the discord a while ago but my problem w the current references is that they reference things that are completely relevant / complete for the cert requirement. |
|
I understand, there's no issue with that. We'll need to troubleshoot it so we can keep it as it is. |
|
I'm working on it btw. I was serving and forgot to run |
|
Found the culprits. The mdx files have an intertwined title and description, and in some cases, the title is duplicated below, sandwiching the description. I'll remove them manually. I don't think there's a reason to keep them, and I assume you're not referring to them when you say "they reference things that are completely relevant / complete for the cert requirement." |
|
Ah good catch Matta - looks like a merge conflict from 0a492cb. @DicksonWu654 I assume you meant "irrelevant / incomplete"? (a) I made a lot of the changes you suggested so it should be better, and (b) you're welcome to make a PR changing anything remaining you don't like. |
|
Ok folks, this should build now. If this was spoken via Discord, I'm sorry I missed it. I even tried looking for it, but just found a debate on the certs channel, not specifically about this failing. Make sure to always add others to review it, and assign it to the steward. And if the steward gets stuck, they are instructed to look for help elsewhere! |
|
Moving this to draft, since it seems to be undergoing a debate between steward @DicksonWu654 and contributor @Robert-MacWha. Let us know when it is ready to be published, or go ahead and do it yourselves after achieving resolution |
|
Hey guys, any info on this PR? |
|
Still the same state as Matta said
…On Mon, Jan 12, 2026 at 5:03 AM Sara Russo ***@***.***> wrote:
*scode2277* left a comment (security-alliance/frameworks#300)
<#300 (comment)>
Hey guys, any info on this PR?
—
Reply to this email directly, view it on GitHub
<#300 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIAWHKIMSV3U2PJTHWKCY3T4GNWNLAVCNFSM6AAAAACNKFUNMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTOMZXG42DMNBYG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Add references to existing frameworks within cert controls where relevant.
Also took notes of all the areas that are distinctly missing refs, attached as a txt file since it's fairly long. We can create sub-issues for the most critical tasks.
certs-notes.txt