Multicam scaffolding: flag, supports_multicam capability, sync metadata helpers - #198
Closed
darioalessandro wants to merge 1 commit into
Closed
Multicam scaffolding: flag, supports_multicam capability, sync metadata helpers#198darioalessandro wants to merge 1 commit into
darioalessandro wants to merge 1 commit into
Conversation
…c metadata helpers Inert groundwork for the multicam director feature (PR0 of the plan): - FeatureFlags.ENABLE_MULTICAM=false master switch; cameras advertise the new supports_multicam capability tied to the flag, so the same release that flips it on starts advertising. - FlatBufferSchemas.fbs: supports_multicam appended to CameraCapabilities (same evolution pattern as supports_focus_point), regenerated with flatc, round-tripped in RemoteCmdSerializationTests including the legacy-peer absent-field default. - CaptureSyncMetadata: the per-clip alignment record (shared director-clock anchor + captureId/sessionId + offset quality) with filename prefix, QuickTime metadata items, and deterministic JSON; unused until synced capture ships. No behavior change; full suite green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
📊 Test Coverage Report✅ 632/644 tests passed · ⏭️ 12 skipped
🎥 Capture & session core
📁 Full report — 88 files
Generated from |
Member
Author
|
Consolidated into the single feature PR per Dario's request: #203 (branch kept, not deleted). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR0 of the multicam director feature plan. Entirely inert:
FeatureFlags.ENABLE_MULTICAM = falsemaster switch.supports_multicamappended toCameraCapabilities(FlatBuffers schema-evolution pattern, regenerated with flatc). Cameras advertise it tied to the flag; legacy peers decode absent asfalse(round-trip tested).CaptureSyncMetadata: per-clip alignment record (shared director-clock anchor, captureId/sessionId, clock-offset quality) with filename prefix, QuickTime metadata items, deterministic JSON. Unused until synced capture ships.No behavior change. Full suite green.
🤖 Generated with Claude Code