Open
Conversation
tschmidtb51
requested changes
May 16, 2025
Contributor
tschmidtb51
left a comment
tschmidtb51
left a comment
There was a problem hiding this comment.
@chirschenberger Please check #128 . IIRC js-joda was introduced for a reason. We shouldn't remove it if that reintroduces an old bug.
Feel free to discuss with @domachine to fix that bug upstream.
christopher-exx
force-pushed
the
196-csaf-2.1_optional_test_6.2.33
branch
from
fa69f54 to
3b4a7df
Compare
Contributor
Author
|
Currently, we use js-joda to compare dates. This causes the test for oasis_csaf_tc-csaf_2_1-2024-6-2-33-02.json to fail because the timezone is specified as -21, while js-joda only supports time zones up to -18. |
christopher-exx
changed the title
rainer-exxcellent
requested review from
domachine
and removed request for
rainer-exxcellent
christopher-exx
force-pushed
the
196-csaf-2.1_optional_test_6.2.33
branch
from
4bc0914 to
c2ffe0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before merging this branch, the issues regarding its incorrect test files have to be fixed (see oasis-tcs/csaf#980 and oasis-tcs/csaf#981)