Skip to content

Plugin update.#24

Open
crisisinaptica wants to merge 4 commits intoseebk:masterfrom
crisisinaptica:update
Open

Plugin update.#24
crisisinaptica wants to merge 4 commits intoseebk:masterfrom
crisisinaptica:update

Conversation

@crisisinaptica
Copy link

@crisisinaptica crisisinaptica commented Oct 7, 2018

New behaviour:

  • Fetch image metadata from gimp instead of reading it from the image
    file.

    This makes possible to execute the plugin on an image that has been
    saved in the native XCF format.

    Currently Exiv2 cannot read metadata from a XCF file.

    Gimp uses Gexiv2. The plugin now needs to link this library too.

Changes in the implementation:

  • Ported from the old, deprecated, 2.8 API to the new one.

    The plugin now uses GEGL buffers instead of 'GimpDrawable's

Miscellanea:

  • Reformat to better suit GIMP coding guidelines and GNU formatting.

  • Fixed a bunch of warns clang tidy was throwing at me.

Sorry, I know this should have been partitioned in several PRs to facilitate code review, but I have done it in a hurry as I needed the plugin to process a bunch of xcf files ASAP.

@seebk
Copy link
Owner

seebk commented Oct 8, 2018

Thanks for all your work, an update to the new 2.10 API is long overdue. However, you are right that this patch would be really difficult to review and merge. It is more or less a complete replacement of the previous source.
If you find a little more time to at least split it into a couple of separate commits that would help me a lot and make it more likely that I find the time to merge it. Please also take care that each commit stands for itself and does not contain whitespace edits like trimming of trailing spaces or tab-to-space conversions etc. There is also a lot of simple reordering of lines which clutters the diff although there is no change in code.

@crisisinaptica
Copy link
Author

crisisinaptica commented Oct 9, 2018 •
edited
Loading

I should have done it properly since the start 🤕

As soon as I have some free time I'll split this into 3 or 4 commits.

@crisisinaptica
Get exif metadata from GIMP instead of reading it from the file
c0c5aad 
Exiv2 does not currently support reading metadata from a XCF file

Since GIMP now keeps an internal copy of the metadata, we can access it
with `gimp_image_get_metadata()` and use Gexiv2 to copy all exif tags to
an empty `Exiv2::ExifData`

(cherry picked from commit 96c139e)
@crisisinaptica
Port to the 2.10 api
5dc6190 
Use GeglBuffers instead of GimDrawable to access pixel data.

(cherry picked from commit 82cf937)
@crisisinaptica
Miscellaneous fixes
00a2088 
Fix some clang tidy warnings.
Consistent use of glib types for numerical values.

(cherry picked from commit 20b6050)
@crisisinaptica
Code formatting
547d92f 
Following the GIMP/GNU C coding style.

https://developer.gimp.org/HACKING
https://www.gnu.org/prep/standards/html_node/Formatting.html#Formatting

(cherry picked from commit 1b2eb75)
@crisisinaptica
Copy link
Author

crisisinaptica commented Oct 11, 2018

@seebk I hope it is now easier to review.

@seebk
Copy link
Owner

seebk commented Oct 20, 2018

Thanks, still a lot of unecessary style changes but think I can look though it and merge the relevant parts.

seebk added a commit that referenced this pull request Oct 21, 2018
@seebk
Get exif data directly from GIMP instead of reading it from the file
c447f1e 
This is the first of a series of patches to port GIMP Lensfun to the new
GIMP 2.10 API. It was originally submitted by crisisinaptica in GitHub
pull request #24 and merged with some changes.

#24
@seebk
Copy link
Owner

seebk commented Oct 21, 2018

I have created a new branch gimp-2.10 were I started to merge and edit your changes.
https://github.com/seebk/GIMP-Lensfun/tree/gimp-2.10
I am quite busy right now, might take some time until it is all there... But it's in the works ;)

seebk added a commit that referenced this pull request Oct 21, 2018
@seebk
Port to GIMP 2.10 API
f2da5b1 
This is the second of a series of patches to port GIMP Lensfun to the new
GIMP 2.10 API. It was originally submitted by crisisinaptica in GitHub
pull request #24 and merged with some changes.

#24
seebk added a commit that referenced this pull request Oct 21, 2018
@seebk
Get exif data directly from GIMP instead of reading it from the image…
2e1a0c2 
… file

This is the first of a series of patches to port GIMP Lensfun to the new
GIMP 2.10 API. It was originally submitted by crisisinaptica in GitHub
pull request #24 and merged with some changes.

#24
seebk added a commit that referenced this pull request Oct 21, 2018
@seebk
Port to GIMP 2.10 plugin API
05d8ecd 
This is the second of a series of patches to port GIMP Lensfun to the new
GIMP 2.10 API. It was originally submitted by crisisinaptica in GitHub
pull request #24 and merged with some changes.

#24
@grahamwhiteuk grahamwhiteuk mentioned this pull request Dec 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisisinaptica @seebk