This repository was archived by the owner on Sep 8, 2023. It is now read-only.
Quoting for capitalised identifiers#12
Open
multimeric wants to merge 1 commit intosegmentio:masterfrom
Open
Conversation
multimeric
referenced
this pull request
in FluidInc/koa-pg-session
Jan 29, 2016
|
+1. This would be the correct behavior. |
|
Excellent --- just what I was about to do myself. Can we get this in? An identifier |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you use an identifer with capitals in it but no special characters, e.g.
someStuff, pg-escape will not quote the identifier. However this will result in postgres automatically converting the identifier to lower case (e.g.somestuff), which can cause some issues with table lookup.This PR simply removes the case insensitive flag from the validIdent function, and adds one line to the tests for this function that checks that it quotes identifiers with capitals.