This repository was archived by the owner on Sep 8, 2023. It is now read-only.
#4 Handle timestamps, numbers, and booleans the same way Postgres format...#5
Open
rpedela wants to merge 2 commits intosegmentio:masterfrom
datalanche:master
Open
#4 Handle timestamps, numbers, and booleans the same way Postgres format...#5rpedela wants to merge 2 commits intosegmentio:masterfrom datalanche:master
rpedela wants to merge 2 commits intosegmentio:masterfrom
datalanche:master
Conversation
Contributor
|
|
Author
|
Tests added and they all pass. |
|
Any chance of this landing in a release any time soon? |
Author
|
@joshgillies Use this instead: https://github.com/datalanche/node-pg-format |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...() does.
I did not run the tests because I could not figure out the command. What is it? I would also be happy to add tests for boolean, Date, and numbers.