Open
Conversation
Add an opt-in debug trace profiling endpoint that breaks transaction replay into timing phases and surfaces historical store lookup costs. Extend the store tracer to record iterator samples and per-operation timing so SS-heavy traces show which keys and scans dominated the replay. Made-with: Cursor
Thread request-scoped read tracing through the SS stack so debug trace profiles can attribute latency to MVCC and Pebble internals like iterator creation, Last, SeekLT, and NextPrefix. Surface the low-level stats alongside the existing store trace so it is clear whether historical lookups are dominated by SS wrapper logic or the underlying Pebble read path. Made-with: Cursor
Instrument the inner getMVCCSlice path so debug trace profiling attributes historical GET latency across iterator creation, Last, key reads, version decoding, value reads, cloning, and iterator close. This makes the dominant historical lookup path explicit instead of burying it inside a single coarse iterator bucket. Made-with: Cursor
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change