-
Notifications
You must be signed in to change notification settings - Fork 18
Fix async flush logic and flaky unit test #122
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (65.38%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 40.00% 40.73% +0.73%
==========================================
Files 59 59
Lines 7510 7534 +24
==========================================
+ Hits 3004 3069 +65
+ Misses 4161 4120 -41
Partials 345 345
🚀 New features to boost your workflow:
|
ss/pebbledb/db.go
Outdated
|
|
||
| func (db *Database) Close() error { | ||
| // First, stop accepting new pending changes and drain the worker | ||
| close(db.pendingChanges) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small note that if Close is called twice for whatever reason close will panic when the channel is already closed. Ditto for rocksdb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, will add a check to make sure it's not called twice
* main: config: fix default value comment (#115)
Describe your changes and provide context
This PR will fix 3 issues:
Testing performed to validate your change