Skip to content

Selego Bug Bounty -Caleb ESHO#16

Open
the-eshocaleb wants to merge 7 commits intoselego:mainfrom
the-eshocaleb:main
Open

Selego Bug Bounty -Caleb ESHO#16
the-eshocaleb wants to merge 7 commits intoselego:mainfrom
the-eshocaleb:main

Conversation

@the-eshocaleb
Copy link
Copy Markdown

@the-eshocaleb the-eshocaleb commented Mar 15, 2025

Summary of Bugs Found

  • When creating a user in the user page, the update button in /user/:id didn't work.
  • When a new project was created and clicked to view its details, there was an error saying "project.name is undefined".
  • Projects were created successfully and could be viewed, but project information like name, description, etc. was empty.
  • In the project edit form, the name field was disabled, preventing users from editing the project name.
  • When deleting a project, users were redirected to "/projects" (which doesn't exist) instead of the project list page.

More details of these bugs and how I solved them are in the comments of my merge requests from fix to main

Summary of Feature Implemented

  • User can create new project with description and objectives at once, there are also default values for the remaining fields
    Why: I think it improves the user experience, saves time and is more efficient. User doesn't have to create a project with just name and then edit to fill in the other required information.

  • Dynamic update of projects list
    Why: It is counter-intuitive for a user to create a project, receive feedback that the project was created successfully, but not see the new project in the project list. User may try to recreate the same project , leading to redundant data and a frustrating experience. To resolve this, once project is created successfully, the state of the projects list is dynamically updated and eliminates the need for the user to refresh the page to see the new project.

Feedback on Code Architecture

  • Redux can be used more extensively for state management.
  • Separate Logic and UI for components into different folder.
  • API endpoints can be better standardised to avoid inconsitent response formats.

Difficulties Encountered

  • I'm more accustomed to model - routes - services fomat for API, so it was a bit confusing initially, but I quickly got the hang of it
  • I found the client code to be a little cluttered, with some components having multiple responsibilities, I think I can improve the readablity and maintainability of the codebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant