docs: add SECURITY.md file#817
Conversation
qlrd
force-pushed
the
docs/security-guidelines
branch
from
3897bb7 to
dbefede
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #817 +/- ##
========================================
Coverage 97.31% 97.31%
========================================
Files 83 83
Lines 10614 10614
========================================
Hits 10329 10329
Misses 285 285 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qlrd
force-pushed
the
docs/security-guidelines
branch
3 times, most recently
from
ebbe2ea to
b4fd3a4
Compare
joaozinhom
left a comment
joaozinhom
left a comment
There was a problem hiding this comment.
I totally agree with this documentation PR, but the links are broken, and don't show me the keys of odudex and jdcl, i also couldn't locate it in the key servers did they publish it?
just to show how i think this should be, following the commands to get my actual pubkey would be simple:
gpg --receive-keys 39163CE12ADCDC208095959B2FDC1C998EC79D5Dand you can find my key in the following links:
https://keyserver.ubuntu.com/pks/lookup?search=39163CE12ADCDC208095959B2FDC1C998EC79D5D&fingerprint=on&op=index
qlrd
force-pushed
the
docs/security-guidelines
branch
from
b4fd3a4 to
ec0fa3d
Compare
qlrd
force-pushed
the
docs/security-guidelines
branch
from
ec0fa3d to
f801625
Compare
| You may use the PGP public key to encrypt your mail: | ||
|
|
||
| ```bash | ||
| curl -s https://api.github.com/users/odudex/gpg_keys | gpg --import |
There was a problem hiding this comment.
this command don't give me the odudex key
There was a problem hiding this comment.
Except for this command this PR looks ready to go to me
There was a problem hiding this comment.
Yup, dumbme. Updated to: curl -s https://api.github.com/users/odudex/gpg_keys | jq -r '.[] | .raw_key' | gpg --import
The `SECURITY.md` file is a important guide that indicate the proper communication means when a security flaw is found and cannot be shared to public.
qlrd
force-pushed
the
docs/security-guidelines
branch
from
f801625 to
44dffc5
Compare
|
ACK 44dffc5 |
2 participants
What is this PR for?
The
SECURITY.mdfile is a important guide that indicate the proper communication means when a security flaw is found and cannot be shared to public.Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?