docs: amend tombstone 대상 계약을 명확히 한다 - #317
Merged
Merged
Conversation
Contributor
Author
|
amend 대상이 live row로 한정되고 superseded tombstone은 의도적으로 제외된다는 실제 계약을 명확히 확인했습니다. tombstone 재생성 시도는 no fact matches와 종료 코드 1로 끝나는 회귀 검증이 추가됐으며, CI 전체가 통과했습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #281
factlog amend의 내부 docstring을 실제 상태 전이 계약에 맞춰 갱신했습니다.candidate,needs_review,accepted,confirmed행은 수정할 수 있지만,superseded행은 이전 정정의 묘비이므로 대상에서 제외됩니다.회귀 검증은 묘비만 일치할 때
amend가 상태를 되살리지 않고no fact matches와 종료 코드 1로 끝나는지를 확인합니다.검증:
PYTHON=/Users/joykim/git/semantic-reasoning/verinote/.venv/bin/python bash tests/test_amend.sh(35 passed).`