[codex] fix string literal escapes - #925
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #924 by teaching the parser lexer to keep scanning through supported string escapes and by decoding those escapes when materializing string token values.
Root Cause
scan_string()stopped at the first"byte without considering a preceding backslash, so an input such as"a\"b"was split early and the full program parse failed. The parser also had its own raw quote-stripping path, so token decoding had no central unescape behavior.Changes
\"and\\while scanning string literals.\"to"and\\to\inwl_parser_lexer_token_to_string().Validation
meson setup build-codex --wipe -Dtests=truemeson test -C build-codex wirelog:lexer wirelog:parser wirelog:string_parsergit diff --cached --check