Skip to content

fix(columnar): reset stratum frontiers on full snapshot re-eval - #930

Merged
justinjoy merged 7 commits into
mainfrom
agent/issue-929-query-snapshot-fix
Jul 16, 2026
Merged

fix(columnar): reset stratum frontiers on full snapshot re-eval#930
justinjoy merged 7 commits into
mainfrom
agent/issue-929-query-snapshot-fix

Conversation

@justinjoy

@justinjoy justinjoy commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes CI regression in issue #929 where tdd_single_key_owner could return 27 instead of 28 tuples after a second snapshot.

Root cause:

  • In full snapshot re-evaluations, IDB was cleared but stratum-level frontiers were not reset.
  • Existing convergence frontiers from a previous epoch could skip required iterations after clear, producing incomplete results.

Change:

  • In col_session_snapshot non-incremental full-recompute path, reset both stratum and rule frontiers to (outer_epoch, UINT32_MAX) so all necessary iterations run.

Validation:

  • meson test -C build tdd_single_key_owner --print-errorlogs
  • meson test -C build wirelog:incremental_insertion wirelog:selective_frontier_reset wirelog:phase4_frontier_integration wirelog:frontier_skip --print-errorlogs
  • meson test -C build wirelog:phase3d_frontier_skip_integration wirelog:delta_propagation wirelog:issue914_nonrec_after_recursive --print-errorlogs

Comment thread tests/test_wirelog_easy.c Dismissed
@justinjoy
justinjoy marked this pull request as ready for review July 16, 2026 10:23
@justinjoy
justinjoy enabled auto-merge (rebase) July 16, 2026 10:23
@justinjoy justinjoy changed the title fix(columnar): repair query-mode snapshot re-evaluation fix(columnar): reset stratum frontiers on full snapshot re-eval Jul 16, 2026
@justinjoy
justinjoy merged commit de0c81b into main Jul 16, 2026
27 checks passed
@justinjoy
justinjoy deleted the agent/issue-929-query-snapshot-fix branch July 16, 2026 11:36
@justinjoy justinjoy mentioned this pull request Jul 30, 2026
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants