fix(columnar): reset stratum frontiers on full snapshot re-eval - #930
Merged
Conversation
justinjoy
marked this pull request as ready for review
July 16, 2026 10:23
justinjoy
enabled auto-merge (rebase)
July 16, 2026 10:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CI regression in issue #929 where
tdd_single_key_ownercould return 27 instead of 28 tuples after a second snapshot.Root cause:
Change:
col_session_snapshotnon-incremental full-recompute path, reset both stratum and rule frontiers to(outer_epoch, UINT32_MAX)so all necessary iterations run.Validation:
meson test -C build tdd_single_key_owner --print-errorlogsmeson test -C build wirelog:incremental_insertion wirelog:selective_frontier_reset wirelog:phase4_frontier_integration wirelog:frontier_skip --print-errorlogsmeson test -C build wirelog:phase3d_frontier_skip_integration wirelog:delta_propagation wirelog:issue914_nonrec_after_recursive --print-errorlogs