fix(columnar): retain canonical input relation names - #934
Merged
Conversation
justinjoy
force-pushed
the
agent/fix-issue-931-relation-name-lifetime
branch
from
July 30, 2026 12:45
8349d31 to
1941e7a
Compare
justinjoy
marked this pull request as ready for review
July 30, 2026 12:45
justinjoy
enabled auto-merge (rebase)
July 30, 2026 12:45
justinjoy
force-pushed
the
agent/fix-issue-931-relation-name-lifetime
branch
from
July 30, 2026 13:14
1941e7a to
98ac976
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The session synchronously resolved a relation but stored the caller-provided
relation-name pointer in
last_inserted_relation/last_removed_relation.Reusing or freeing that buffer before
step()orsnapshot()changed thelater affected-strata lookup and could silently suppress incremental deltas.
The pending state now stores the canonical
col_rel_t::name, whose lifetimeis owned by the session.
Validation
deltas=1, exit 0 (previouslydeltas=0, exit 14)git diff --checkCloses #931