docs: developer guides for executors, Docker images, and workflows#3983
Draft
cursor[bot] wants to merge 1 commit into
Draft
docs: developer guides for executors, Docker images, and workflows#3983cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Add docs/developer/ index with guides for runner executors (local/docker/k8s),
Docker job/helper images, Pro workflows, and the HA cluster dashboard API
- Document job and helper images in deployment/docker/README.md
- Remove duplicate SQLite section in deployment/compose/README.md
- Align workflow swagger with implementation (note node kind, stopped status,
POST …/runs/{run_id}/stop)
- Link developer docs from README and CONTRIBUTING
Co-authored-by: Denis Gukov <fiftin@outlook.com>
Contributor
|
Maybe I'm mistaking but doesn't the docker/k8s runner not also enable usage of ansible execution environments? This would allow users bringing their own EE, so that you don't have to mount a For this to work, the image that runs the job should be overwritable at template level though, and from what I saw, you can currently just specify one image per runner, right? If this was overwritable per template, it could be a big selling point for you guys, as everyone who is currently using AAP, already has an EE for their ansible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds in-repo developer documentation for recently shipped subsystems that lacked contributor-facing guides.
Docs added/updated
docs/developer/README.mddocs/developer/runner-executors.mdlocal/docker/k8sexecutor strategies, config keys, env vars, OSS vs Prodocs/developer/docker-images.mdserver,runner,job, andhelperimages — roles, contents, CI publishingdocs/developer/workflows.mddocs/developer/ha-cluster-dashboard.mddeployment/docker/README.mddeployment/compose/README.mdapi-docs.ymlnotenode kind,stoppedrun status,POST …/runs/{run_id}/stopREADME.md,CONTRIBUTING.mddocs/developer/Codepaths covered
services/runners/executor_factory.go,util/config.go— runner executor configurationdeployment/docker/job/,deployment/docker/helper/— executor container imagesdb/Workflow.go,api/router.go,pro_interfaces/workflow_*.go— workflowsapi/cluster.go— HA cluster dashboard APIKnowledge gaps addressed
job/helperimages published by CIAGENTS/plansnotes only — no contributor-facing architecture or API referencestoppedstatus