[SC-23705] fix(sematext): prevent field name corruption on re-processing#18
Merged
boratanrikulu merged 1 commit intoJan 30, 2026
Merged
Conversation
The fallback in Rename.Process() was using ChangeNames(key) where key included the measurement prefix. This caused field names to accumulate prefixes when metrics were re-processed: BEFORE: measurement="etcd", field="slow_requests" → "etcd.slow.requests" AFTER: measurement="etcd", field="slow_requests" → "slow.requests" For mapped fields (apache, nginx, etc.) there is no change - they use fieldReplaces mappings. The fix ensures idempotency: processing a metric multiple times no longer corrupts field names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Technical Details
Root Cause
The fallback in
Rename.Process()was usingChangeNames(key)wherekeyincluded the measurement prefix (originalName + "." + field.Key). This caused field names to accumulate prefixes when metrics were re-processed.Test Results (Before Fix)
Running
TestRenameIdempotentshows the corruption accumulating with each pass:Each pass through the processor adds another
"apache."prefix!The Fix
Use
ChangeNames(field.Key)directly instead ofChangeNames(key):Impact
For mapped fields (apache, nginx, mongodb, etc.): No change - they use
fieldReplacesmappings as before.For unmapped fields (e.g., etcd):
The fix ensures idempotency: processing a metric multiple times no longer corrupts field names.
Test Plan
TestRenameIdempotentto verify field names remain stable across multiple passesgo test ./plugins/outputs/sematext/...