fix(docker-compose): support files without version - #4037
Open
fyrsta7 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to an issue
Fixes #4035.
Summary
Modern Docker Compose files can omit the obsolete top-level
versionfield, but six Docker Compose security rules currently require it before they can match. This causes false negatives for valid versionless Compose files.This change:
versionrequirement from all six affected Docker Compose security rules;services;jobs.<job>.services;The GitHub Actions exclusion preserves the false-positive protection introduced in #1241 while allowing current Compose syntax.
Two touched rules also update their discouraged
CWE-284metadata toCWE-250: Execution with Unnecessary Privileges, which matches related container-confinement rules and satisfies the current changed-file lint.Testing
semgrep validate yaml/docker-compose/securitysemgrep test yaml/docker-compose/security(6/6 passed)returntocorp/semgrep:1.163.0git diff --check