Skip to content
This repository was archived by the owner on Aug 28, 2020. It is now read-only.

Partially fixes #5#163

Open
chatpion wants to merge 1 commit into
sendgrid:masterfrom
chatpion:issue-5
Open

Partially fixes #5#163
chatpion wants to merge 1 commit into
sendgrid:masterfrom
chatpion:issue-5

Conversation

@chatpion
Copy link
Copy Markdown

@chatpion chatpion commented Oct 26, 2018

Fixes

Partially fixes #5

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Replace all variables with a single dict based on PackageManagerData (keys are attributes containing "download").

@chatpion
Partially fix #5
cb97996 
Replace all variables with a single dict based on PackageManagerData
(keys are attributes containing "download").
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium status: code review request status: hacktoberfest approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make update_package_manager_data and update_db generic

2 participants

@chatpion @thinkingserious