remove os.path.exists checks so we can also work with files over http#39
Open
rdkls wants to merge 1 commit intosenko:masterfrom
Open
remove os.path.exists checks so we can also work with files over http#39rdkls wants to merge 1 commit intosenko:masterfrom
rdkls wants to merge 1 commit intosenko:masterfrom
Conversation
x1ah
approved these changes
Dec 17, 2017
|
+1，remove path check is better. |
Author
|
I notice the CI failure isn't related to that code :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know you guys put those checks there to be safe, but the code seems to fail nicely enough if files don't exist without them =) I needed it just for my case, to work with files over HTTP (kinda cool!)