fix(rules,http): linearTyped value loss and RequestBuilder raw-body JSON coercion - #10
Merged
Merged
Conversation
…stBuilder raw bodies - RuleEngine.linearTyped/linearTypedAsync now return the last rule's value on success instead of always returning an Empty failure. - fetchResult gains a send() method and RequestBuilder now uses it for non-JSON POST/PUT/PATCH bodies, so raw bodies set via .body() are no longer forced through JSON.stringify. - Add regression tests for both fixes and correct the agent-skill docs that had documented the old buggy behavior.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RuleEngine.linearTyped/linearTypedAsyncalways returned anEmptyfailure on success instead of the last rule's value — fixed to track and return the last value, matchingandTyped/andTypedAsync.RequestBuilder.send()always routed POST/PUT/PATCH throughfetchResult.post/put/patch, whichJSON.stringifys its body argument — so a raw body set via.body()(e.g. plain text, FormData) got double-encoded/corrupted. AddedfetchResult.send()and wiredRequestBuilderto use it for non-JSON bodies.src/behavior changed.Test plan
npm test— 1089/1089 passingnpm run typechecknpm run check(Biome lint + format)npm run build