Skip to content

Role based access control#72

Open
tekrajchhetri wants to merge 27 commits intomainfrom
user-rbac
Open

Role based access control#72
tekrajchhetri wants to merge 27 commits intomainfrom
user-rbac

Conversation

@tekrajchhetri
Copy link
Copy Markdown
Collaborator

@tekrajchhetri tekrajchhetri commented May 4, 2026

This PR adds the RBAC.

Please note that it also contains some old design doc info and can be ignored for this review.

Important: Merge #73 first before merging this.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request integrates the usermanagement_service into the unified Docker deployment and significantly expands its functionality. Key additions include OAuth authentication support for GitHub, ORCID, and Globus, a comprehensive role-based access control (RBAC) system with permissions and page-level restrictions, and administrative capabilities such as user banning. The update also introduces an environment variable drift detection script and detailed design documentation. Review feedback identifies a security risk concerning encryption key fallbacks, data integrity concerns during profile deletion, and a recommendation to use SQLAlchemy's expression language for database queries to ensure consistency.

Comment thread usermanagement_service/core/security.py
Comment thread usermanagement_service/core/routers/user_management.py
Comment thread usermanagement_service/core/database.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant