Document minimal Shiny UI config for advanced models#36
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughSummary by CodeRabbit문서화
Walkthroughinst/shiny-app/README.md에 "Minimal UI Configuration for Advanced Models" 섹션을 추가하고, 관련 문장 리플로우와 목록 형식 수정을 적용했습니다. 실행 로직이나 공개 API 변경은 없습니다. (문서 텍스트 변경만 있음, 0개의 코드 변경) Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
1 similar comment
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
inst/shiny-app/README.md (1)
25-28:⚠️ Potential issue | 🟡 Minor기존 문서와의 일관성 검토 필요
25-28번째 줄의 "Configure Model" 섹션에서는 3가지 구성 옵션(요인 범위, 회전 방법, 모델 선택 기준)만 언급하는 반면, 새로 추가된 55-56번째 줄에서는
saveModelHistory를 "권장(recommended)" 옵션으로 소개하고 있습니다.만약
saveModelHistory가 고급 설정을 위한 중요한 옵션이라면, "Using the Interface" 섹션에도 언급되어야 일관성이 유지됩니다.📝 일관성 개선을 위한 제안
"Configure Model" 섹션에 saveModelHistory 옵션 추가:
2. **Configure Model**: - Set minimum and maximum number of factors to explore - Choose rotation method (bifactorQ recommended for most cases) - Select model selection criteria (DIC is default) + - Enable model history saving to inspect candidate models (optional but recommended)Also applies to: 55-56
🤖 Fix all issues with AI agents
In `@inst/shiny-app/README.md`:
- Around line 58-59: The sentence containing "These controls, along with data
upload/validation and a run button, are the minimum set..." is ambiguous about
whether "data upload/validation" and the "run button" are part of the UI
controls or separate implementation tasks and what "data validation" entails;
update the README text to explicitly state whether these elements are UI
components or backend steps and provide a short concrete definition of "data
validation" (e.g., schema/type checks, missing-value handling, and format
validation) and list which parts must be implemented in the UI versus server
logic so readers know exactly what to build and where (refer to the exact phrase
"data upload/validation and a run button" to find the sentence to edit).
- Around line 44-60: Update the README examples to include the full set of
supported model selection criteria and to mention the model history toggle: add
`AICc` and `saBIC` to the "Model selection criteria" example that maps to
`modelSelectionCriteria` (so it lists `DIC`, `AIC`, `AICc`, `BIC`, `saBIC`), and
also add a note about the `saveModelHistory` checkbox in the "Using the
Interface" section so the docs consistently recommend enabling model history for
inspecting candidate models when calling `aefa()`.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@inst/shiny-app/README.md`:
- Around line 70-72: The README claims missing-value handling follows a
user-selected policy but there is no UI control or parameter to set this; update
the Shiny app and API: add a missing-value policy input in the UI (app.R) —
e.g., a radio/select input for policies like "remove (na.rm=TRUE)", "impute
mean", "flag error" — propagate that input to server-side validation and pass it
into aefa() (or add a new aefa(missing_policy=...) parameter) so server logic
validates CSV schema/types, applies the chosen policy to handle NAs before
calling aefa(), or alternatively edit the README text to explicitly state that
aefa() currently uses a fixed na.rm=TRUE default if you do not want to change
code.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@inst/shiny-app/README.md`:
- Line 66: 문구 "file upload control and data preview controls"가 모호하므로 README의 해당
문장을 수정해 명확히 하세요: 데이터 미리보기가 선택적이면 "optionally, data preview controls"로 변경하거나 필수이면
구체적으로 어떤 UI 요소인지(예: "data table display for uploaded CSV" 또는 "preview pane
showing first N rows")로 명시하거나 필요 없다면 문장에서 제거하세요; 변경 대상은 README의 해당 문구와 동일한 문장이고
관련 문맥은 "Using the Interface" 섹션(초반 설명)과 일관되게 업데이트해야 합니다.
- Around line 70-74: Update the README guidance so server-side validation before
calling aefa() lists concrete checks: verify CSV column names and types (e.g.,
all item columns are numeric), confirm item-response ranges (e.g., values within
1–5 or configurable), detect and count missing values (NA/empty cells) and
surface a clear warning message with counts, and validate expected item-response
layout (rows=respondents, columns=items); state that missing-value handling will
follow aefa() defaults unless the app author adds a custom missing-value policy
control in their Shiny server logic.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
seonghobae
dismissed stale reviews from coderabbitai[bot], coderabbitai[bot], and coderabbitai[bot]
Superseded by latest documentation updates and resolved threads.
Summary
Testing
Closes #35