[INFRA] Update cmake version from 3.11.4 to 3.22.2#196
Draft
Irallia wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Lydia Buntrock <lydia.buntrock@fu-berlin.de>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #196 +/- ##
=======================================
Coverage 98.41% 98.41%
=======================================
Files 19 19
Lines 882 885 +3
=======================================
+ Hits 868 871 +3
Misses 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joergi-w
requested changes
Mar 1, 2022
| @@ -1,4 +1,4 @@ | |||
| cmake_minimum_required (VERSION 3.11) | |||
| cmake_minimum_required (VERSION 3.22) | |||
Member
There was a problem hiding this comment.
This is dangerous: Cmake v3.22 is younger than 3 months and almost everyone will run into build problems! FU has v3.18 on their servers, MPI has v3.16. Which functions of v3.22 are you actually using?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.