Skip to content

fix(cli): Write rule load trace to ~/.opentaint logs dir #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
misonijnik merged 1 commit into from
Jun 16, 2026
Merged

fix(cli): Write rule load trace to ~/.opentaint logs dir #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions cli/cmd/scan.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,16 @@ func runScan(cmd *cobra.Command, cfg ScanConfig) {

uriBase := fmt.Sprintf("%s%s", sourceRoot, string(filepath.Separator))

ruleLoadTraceDir, err := utils.GetProjectLogPath(absUserProjectRoot)
if err != nil {
out.Fatalf("Failed to resolve rule load trace directory: %v", err)
}

var absSemgrepRuleLoadTracePath string
if cfg.DryRun {
absSemgrepRuleLoadTracePath = filepath.Join(os.TempDir(), dryRunRuleLoadTraceFileName)
absSemgrepRuleLoadTracePath = filepath.Join(ruleLoadTraceDir, dryRunRuleLoadTraceFileName)
} else {
absSemgrepRuleLoadTracePath = setupSemgrepRuleLoadTrace()
absSemgrepRuleLoadTracePath = setupSemgrepRuleLoadTrace(ruleLoadTraceDir)
}

// Display scan information in tree format
Expand Down Expand Up @@ -564,8 +569,8 @@ func printScanInfo(cmd *cobra.Command, plan scanPlan, absSemgrepRuleLoadTracePat
sb.Render()
}

func setupSemgrepRuleLoadTrace() string {
absSemgrepRuleLoadTracePath, err := load_trace.GenerateSemgrepRuleLoadTraceFilePath()
func setupSemgrepRuleLoadTrace(traceDir string) string {
absSemgrepRuleLoadTracePath, err := load_trace.RuleLoadTracePathIn(traceDir)
if err != nil {
out.Fatalf("Failed to generate rule load trace file path: \"%s\": %v", absSemgrepRuleLoadTracePath, err)
}
Expand Down
10 changes: 4 additions & 6 deletions cli/internal/load_trace/gen_rule_load_trace_file_name.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,6 @@ type PathBuilder struct {
// NewPathBuilder creates a new PathBuilder with default settings
func NewPathBuilder() *PathBuilder {
return &PathBuilder{
baseDir: os.TempDir(),
subDir: filepath.Join("opentaint", "rule_load_trace"),
filePrefix: "",
fileSuffix: ".json",
timeFormat: "2006-01-02_15-04-05",
permissions: 0755,
Expand Down Expand Up @@ -77,7 +74,8 @@ func (pb *PathBuilder) Build() (string, error) {
return filePath, nil
}

// GenerateSemgrepRuleLoadTraceFilePath creates a trace file path using default settings (backward compatibility)
func GenerateSemgrepRuleLoadTraceFilePath() (string, error) {
return NewPathBuilder().Build()
// RuleLoadTracePathIn builds a rule-load-trace file path inside dir, e.g.
// <dir>/rule-load-trace-2006-01-02_15-04-05.json, creating dir if needed.
func RuleLoadTracePathIn(dir string) (string, error) {
return NewPathBuilder().BaseDir(dir).FilePrefix("rule-load-trace-").Build()
}
Loading