Skip to content

Refactor/tests#169

Merged
MAfarrag merged 19 commits into
mainfrom
refactor/tests
Mar 31, 2026
Merged

Refactor/tests#169
MAfarrag merged 19 commits into
mainfrom
refactor/tests

Conversation

@MAfarrag

@MAfarrag MAfarrag commented Mar 30, 2026

Copy link
Copy Markdown
Member

Description

Normalize the package to lowercase, adopt snake_case naming conventions,
rename the GitHub organization, add multi-encoding D8 flow direction
support, and fix documentation build.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Issues

How Has This Been Tested?

  • 77 new unit tests for DEM.flow_direction_index covering all three
    D8 encodings (ESRI, SAGA, GRASS), validation, no-data handling,
    cross-encoding consistency, and edge cases.
  • Full test suite passes: pixi run -e dev pytest -vvv -m "not fig_share"
  • mkdocs build succeeds: pixi run -e docs mkdocs build

Checklist:

  • updated version number in pyproject.toml
  • updated environment.yml and the lock file
  • added changes to History.rst
  • updated the latest version in README file
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MAfarrag MAfarrag self-assigned this Mar 31, 2026
@MAfarrag
MAfarrag merged commit c38d7cb into main Mar 31, 2026
10 checks passed
@MAfarrag
MAfarrag deleted the refactor/tests branch March 31, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment