Fix the MaximumPayloadLengthChars#54
Draft
0xced wants to merge 1 commit intoserilog:devfrom
Draft
Conversation
The [EventLog.WriteEntry documentation][1] says the maximum is 31839 but it was found empirically that the maximum is 31718 on Windows 10. The `UsingSuperLongLogMessageWorks` test now passes again. [1]: https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.eventlog.writeentry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EventLog.WriteEntry documentation says the maximum is 31839 but it was found empirically that the maximum is 31718 on Windows 10.
The
UsingSuperLongLogMessageWorkstest now passes again.Note: I have opened this pull request as draft because I also opened dotnet/dotnet-api-docs#9999 which proposes to change the official documentation about the maximum message size. So let's see what the documentation team has to say about it first...