Conversation
|
Current state: 2313 successful tests |
53e8e41 to
d93f388
Compare
|
Current state: 4098 successful tests |
4be7d1f to
7f90859
Compare
|
Current state: 4159 successful tests |
fe59427 to
c674a9d
Compare
|
Current state: 4414 successful tests |
c674a9d to
5d333b1
Compare
187fe7b to
0a574dc
Compare
|
Doesn't depend on #6 anymore. |
8c941c1 to
62d1649
Compare
62d1649 to
b8d1044
Compare
| continue | ||
| out.append(arg * ExprInt(count, expr.size)) | ||
| elif count < 0: | ||
| out.append(arg * (-ExprInt(-count, expr.size))) |
There was a problem hiding this comment.
This may be counter productive:
The next step in simplification will be to test if we have - ExprInt(XXX) and transform this to ExprInt(-XXX)
There was a problem hiding this comment.
Indeed, I added this when the ExprInt constructor was bugged and forgot to remove it.
| return bs.get_bytes_exact(offset, l) | ||
|
|
||
| @classmethod | ||
| def endian_offset(cls, attrib, offset): |
There was a problem hiding this comment.
as you are in cpu.py, maybe this fuction should be named "endian_offset_u32" or something approaching?
| self.nofollow.add(expr) | ||
| return None | ||
| elif expr.is_function_call(): | ||
| elif expr.is_op() and expr.is_function_call(): |
There was a problem hiding this comment.
Maybe we can mimic the python code:
bind is_function_code to each miasm expr so that we don't have to test the nature of expr
(is_function_code points is to have a shortcut to test this. so having a first test to do before is a bit counter productive ?)
There was a problem hiding this comment.
Requires a modification to the Rust code, implemented in https://github.com/serpilliere/miasm-rs/pull/76
b8d1044 to
50440d9
Compare
…p the generated shellcodes after the tests have ended
The goal is to validate the tests without migrating everything yet.
… source directory
This allows tests to be skipped entirely automatically if a missing (optional) dependency is imported, without needing to edit the regular Miasm code. If the code is called without PyTest, the normal ImportError is raised (unchanged behavior).
… have our own system instead
50440d9 to
e9ce843
Compare
2 participants
Depends on https://github.com/serpilliere/miasm-rs/pull/74.
Rewrite of the different tests to improve visibility on test results (see the different failures within a single file, better traceback, less intensive parallelization for faster tests).
Fixes various small issues in the project (deprecated API calls…)