docs: Add GitHub IDP docs #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
marcelomendoncasoares
requested changes
Jan 28, 2026
Collaborator
marcelomendoncasoares
left a comment
marcelomendoncasoares
left a comment
There was a problem hiding this comment.
Thanks for the quick iteration with the docs, @vfiruz97! Docs looks good overall, following the standard of the other IDPs very well. Made a few suggestions to clarify some points and reorganize some details to improve the UX.
On the custom overrides, I think we'll need to convert it into a menu following the same style of the IDPs - after all, it is just like an IDP. The file is currently very long and with parts that can be removed to avoid redundancy.
Ping me back when you are ready for another review!
docs/06-concepts/11-authentication/04-providers/06-github/01-setup.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/06-github/01-setup.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/06-github/01-setup.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/06-github/01-setup.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/06-github/01-setup.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/10-custom-providers/02-oauth2-utility.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/10-custom-providers/02-oauth2-utility.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/10-custom-providers/02-oauth2-utility.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/10-custom-providers/02-oauth2-utility.md
Outdated
Show resolved
Hide resolved
docs/06-concepts/11-authentication/04-providers/10-custom-providers/02-oauth2-utility.md
Outdated
Show resolved
Hide resolved
Author
|
Hi @marcelomendoncasoares, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs serverpod/serverpod#4546.
@marcelomendoncasoares, please, review.