Skip to content
This repository was archived by the owner on Dec 16, 2024. It is now read-only.

Improve TLS config#974

Closed
Darkspirit wants to merge 1 commit intoservo:masterfrom
Darkspirit:tls
Closed

Improve TLS config#974
Darkspirit wants to merge 1 commit intoservo:masterfrom
Darkspirit:tls

Conversation

@Darkspirit
Copy link
Copy Markdown

@Darkspirit Darkspirit commented Aug 1, 2019

#973 (comment)

iirc last time I made this change I broke our buildbot CI completely. This will need to wait until I see convincing evidence that that won't happen again.

Do you mean #913 (comment)?
You broke it under stress without further notice. :-/
It was like changing http://example.com:80/ to https://example.com:80/.
HTTPS is only configured on nginx port 443.

In particular, I believe that there are some python-based HTTP requests for build.servo.org that see a 301 response and raise an exception.

As far as I can see port 80 is only used by web UI. If the transition is done, port 80 can anyway be closed, so I didn't touch it.


This change is Reviewable

@Darkspirit Darkspirit closed this Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants