glFlush before presenting a bound surface on CGL#380
Merged
mrobinson merged 1 commit intoJun 11, 2026
Conversation
The old API (unbinding, presenting, binding) caused a flush incidentally, but the new API does not. Flushes are necessary on macOS only due to the fact that presenting is a CoreAnimation-only concept. Without flushing the OpenGL commands they might not make it to the GPU before the CoreAnimation work. The flush ensures they do. Also bump the version, so that Servo can take advantage of this fix immediately. Signed-off-by: Martin Robinson <mrobinson@abandonedwig.info>
mukilan
approved these changes
Jun 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old API (unbinding, presenting, binding) caused a flush
incidentally, but the new API does not. Flushes are necessary on macOS
only due to the fact that presenting is a CoreAnimation-only concept.
Without flushing the OpenGL commands they might not make it to the GPU
before the CoreAnimation work. The flush ensures they do.
Also bump the version, so that Servo can take advantage of this fix
immediately.